Code Monkeyism

Programming is hard by Stephan Schmidt

January 11, 2008

Once and for all: Do not use double for money

The discussion on how to represent money in applications pops up regularly . Funny lots of people still use double to represent money. During my interviews some people use double for money. Once and for all: Do not use double. Double cannot represent all amounts of money and it has rounding problems. Use a Money class. Represent the amount with a BigDecimal in cents and use BigDecimal.ROUND_HALF_EVEN as your rounding method. Use a distribute algorithm to distribute money to severel slots without losing cents.

Read more about a money class from Martin Fowler or this TSS discussion. Anders writes about Money in .NET.

Rant off. Thanks for not using double anymore.

If you liked this post, subscribe to my free full RSS feed.
Filed under: Java

You can share this post!
Do you want to tell others about this article? Use the social bookmark icons to submit this artice to the service of your choice. Thanks.

Get free updates by email

If you did like this article you can get free updates with your RSS reader, you can follow me on Twitter or get free update to new posts by email. Enter your email:

 
About the author: Stephan has been working as a head of development and CTO. He has experiences in different technologies since 20 years including Java, Rails and Python. Stephans main field of interest is maintainablity and productivity in software development. Want to know more? All views are only his own.

Comments

digital.alterego

What do you mean with “Use a distribute algorithm to distribute money to severel slots without loosing cents.”? Could you please explain this further? Anyway thanks for the links, good discussions there.

January 11th, 2008
stephan

@digital.alterego: Fowler calls it allocate I guess. You have 3 people and need to distribute (allocate) 10 EUR to them. 10/3 = 3.33 in cents, which means 1 cent is lost. Distributing 10 EUR correctly will result in 3 buckets [3.33, 3.33, 3.34].

January 11th, 2008
Eric Burke

I always distribute as [3.33, 3.33, 3.33] and then deposit 0.01 into my own secret account.

January 12th, 2008
stephan

The comic hero, I´m really honoured.

A lot of people tried this, most of them got caught when getting greedy :-)

January 12th, 2008
Greg Miller

Quote:
————————–
I always distribute as [3.33, 3.33, 3.33] and then deposit 0.01 into my own secret account.
————————–

Just make sure you don’t mess up on some mundane detail like putting a decimal point in the wrong place.

But seriously, it’s been my opinion for a while that using float or double should cause a compiler warning optionally suppressed by a compiler flag. I believe the only place a typical programmer would run into floats being used correctly would be 3D graphics programming.

January 14th, 2008
Finds of the Week - December 13, 2008 » Chinh Do

[...] Stephan advised to use the "money" data type to store currency amounts instead of doubles. For good reasons. [...]

January 14th, 2008
stephan

@Greg: I have the same feeling. Developers using double or float do use the wrong type in most cases except for 3D graphics or statistics.

January 14th, 2008
FEZ

I don’t know about USA, but in Europe you would use ROUND_HALF_UP for money rounding!?

January 14th, 2008
stephan

ROUND_HALF_EVEN is called fair rounding because it distributes the error. It’s also called bankers rounding.

http://en.wikipedia.org/wiki/Rounding#Round-to-even_method

“Rounding mode to round towards the “nearest neighbor” unless both neighbors are equidistant, in which case, round towards the even neighbor. Behaves as for ROUND_HALF_UP if the digit to the left of the discarded fraction is odd; behaves as for ROUND_HALF_DOWN if it’s even. Note that this is the rounding mode that minimizes cumulative error when applied repeatedly over a sequence of calculations.”

http://java.sun.com/j2se/1.5.0/docs/api/java/math/BigDecimal.html#ROUND_HALF_EVEN

January 14th, 2008
BigDecimal money cookbook at Stephans Blog

[...] No signal, no noise. « Once and for all: Do not use double for money [...]

January 14th, 2008
FEZ

http://en.wikipedia.org/wiki/Rounding#Round-to-even_method:

“The origin of the term bankers’ rounding is more obscure. If this rounding method was ever a standard in banking, the evidence has proved extremely difficult to find. To the contrary, section 2 of the European Commission report The Introduction of the Euro and the Rounding of Currency Amounts [2] suggests that there had previously been no standard approach to rounding in banking.”

January 14th, 2008
Alex

funny enough, but Fowler did use double for money amount in his examples :-)

February 27th, 2009
stephan

Alex: Sure?

Looking at page 491 of Patterns of Enterprise Application Architecture he explicitly discourages the use of floats and suggests using long (See google book search).

February 27th, 2009

Leave a Reply